lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/6] dt-bindings: opp: Introduce qcom-opp bindings
Date


On 05/26/2018 04:03 AM, David Collins wrote:
> Hello Rajendra,
>
> On 05/25/2018 03:01 AM, Rajendra Nayak wrote:
>> On Qualcomm platforms, an OPP node needs to describe an
>
> s/Qualcomm/Qualcomm Technologies, Inc./
>
>

[] ..

>
> s/Qualcomm/Qualcomm Technologies, Inc./ ?
>
> s/descibe/describe/
>
>
>> +
>> +OPP tables for devices on Qualcomm platforms require an additional
>
> s/Qualcomm/Qualcomm Technologies, Inc./
>
>
>> +platform specific corner/level value to be specified.
>> +This value is passed on to the RPM (Resource Power Manager) by
>
> Do you want to mention RPMh here as well?
>
>

[] ..

>> +
>> +Required properties:
>> +- qcom,level: On Qualcomm platforms an OPP node can describe a positive value
>
> s/Qualcomm/Qualcomm Technologies, Inc./
>
>
>> +representing a corner/level that's communicated with a remote microprocessor
>> +(usually called the RPM) which then translates it into a certain voltage on
>> +a voltage rail.
>
> Should these lines be indented 2 spaces as is the case for the compatible
> property above?
>
> Could you add an example for both RPM and RPMh in this binding file?

Thanks David for the review. I will fix all this up when I respin.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

\
 
 \ /
  Last update: 2018-05-29 11:51    [W:0.077 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site