lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 326/496] z3fold: fix memory leak
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Xidong Wang <wangxidong_97@163.com>

    [ Upstream commit 1ec6995d1290bfb87cc3a51f0836c889e857cef9 ]

    In z3fold_create_pool(), the memory allocated by __alloc_percpu() is not
    released on the error path that pool->compact_wq , which holds the
    return value of create_singlethread_workqueue(), is NULL. This will
    result in a memory leak bug.

    [akpm@linux-foundation.org: fix oops on kzalloc() failure, check __alloc_percpu() retval]
    Link: http://lkml.kernel.org/r/1522803111-29209-1-git-send-email-wangxidong_97@163.com
    Signed-off-by: Xidong Wang <wangxidong_97@163.com>
    Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Vitaly Wool <vitalywool@gmail.com>
    Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    mm/z3fold.c | 9 +++++++--
    1 file changed, 7 insertions(+), 2 deletions(-)

    --- a/mm/z3fold.c
    +++ b/mm/z3fold.c
    @@ -469,6 +469,8 @@ static struct z3fold_pool *z3fold_create
    spin_lock_init(&pool->lock);
    spin_lock_init(&pool->stale_lock);
    pool->unbuddied = __alloc_percpu(sizeof(struct list_head)*NCHUNKS, 2);
    + if (!pool->unbuddied)
    + goto out_pool;
    for_each_possible_cpu(cpu) {
    struct list_head *unbuddied =
    per_cpu_ptr(pool->unbuddied, cpu);
    @@ -481,7 +483,7 @@ static struct z3fold_pool *z3fold_create
    pool->name = name;
    pool->compact_wq = create_singlethread_workqueue(pool->name);
    if (!pool->compact_wq)
    - goto out;
    + goto out_unbuddied;
    pool->release_wq = create_singlethread_workqueue(pool->name);
    if (!pool->release_wq)
    goto out_wq;
    @@ -491,8 +493,11 @@ static struct z3fold_pool *z3fold_create

    out_wq:
    destroy_workqueue(pool->compact_wq);
    -out:
    +out_unbuddied:
    + free_percpu(pool->unbuddied);
    +out_pool:
    kfree(pool);
    +out:
    return NULL;
    }


    \
     
     \ /
      Last update: 2018-05-28 14:51    [W:2.116 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site