lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 361/496] ACPI: acpi_pad: Fix memory leak in power saving threads
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lenny Szubowicz <lszubowi@redhat.com>

    [ Upstream commit 8b29d29abc484d638213dd79a18a95ae7e5bb402 ]

    Fix once per second (round_robin_time) memory leak of about 1 KB in
    each acpi_pad kernel idling thread that is activated.

    Found by testing with kmemleak.

    Signed-off-by: Lenny Szubowicz <lszubowi@redhat.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/acpi/acpi_pad.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/acpi/acpi_pad.c
    +++ b/drivers/acpi/acpi_pad.c
    @@ -110,6 +110,7 @@ static void round_robin_cpu(unsigned int
    cpumask_andnot(tmp, cpu_online_mask, pad_busy_cpus);
    if (cpumask_empty(tmp)) {
    mutex_unlock(&round_robin_lock);
    + free_cpumask_var(tmp);
    return;
    }
    for_each_cpu(cpu, tmp) {
    @@ -127,6 +128,8 @@ static void round_robin_cpu(unsigned int
    mutex_unlock(&round_robin_lock);

    set_cpus_allowed_ptr(current, cpumask_of(preferred_cpu));
    +
    + free_cpumask_var(tmp);
    }

    static void exit_round_robin(unsigned int tsk_index)

    \
     
     \ /
      Last update: 2018-05-28 14:45    [W:4.600 / U:0.776 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site