lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 175/272] drm/meson: Fix an un-handled error path in meson_drv_bind_master()
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit e770f6bf18182bc3af6ceec30189b6c323cbc157 ]

    'drm_vblank_init()' can fail. So handle this (unlikely) error.

    Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Acked-by: Neil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/6cbf3d70ac3904489c7194c895225c4103aebb96.1520885192.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/meson/meson_drv.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/meson/meson_drv.c
    +++ b/drivers/gpu/drm/meson/meson_drv.c
    @@ -230,7 +230,10 @@ static int meson_drv_bind_master(struct

    priv->vsync_irq = platform_get_irq(pdev, 0);

    - drm_vblank_init(drm, 1);
    + ret = drm_vblank_init(drm, 1);
    + if (ret)
    + goto free_drm;
    +
    drm_mode_config_init(drm);
    drm->mode_config.max_width = 3840;
    drm->mode_config.max_height = 2160;

    \
     
     \ /
      Last update: 2018-05-28 13:41    [W:2.880 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site