lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 213/272] enic: enable rq before updating rq descriptors
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Govindarajulu Varadarajan <gvaradar@cisco.com>

    [ Upstream commit e8588e268509292550634d9a35f2723a207683b2 ]

    rq should be enabled before posting the buffers to rq desc. If not hw sees
    stale value and casuses DMAR errors.

    Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/cisco/enic/enic_main.c | 10 +++++++---
    1 file changed, 7 insertions(+), 3 deletions(-)

    --- a/drivers/net/ethernet/cisco/enic/enic_main.c
    +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
    @@ -1898,6 +1898,8 @@ static int enic_open(struct net_device *
    }

    for (i = 0; i < enic->rq_count; i++) {
    + /* enable rq before updating rq desc */
    + vnic_rq_enable(&enic->rq[i]);
    vnic_rq_fill(&enic->rq[i], enic_rq_alloc_buf);
    /* Need at least one buffer on ring to get going */
    if (vnic_rq_desc_used(&enic->rq[i]) == 0) {
    @@ -1909,8 +1911,6 @@ static int enic_open(struct net_device *

    for (i = 0; i < enic->wq_count; i++)
    vnic_wq_enable(&enic->wq[i]);
    - for (i = 0; i < enic->rq_count; i++)
    - vnic_rq_enable(&enic->rq[i]);

    if (!enic_is_dynamic(enic) && !enic_is_sriov_vf(enic))
    enic_dev_add_station_addr(enic);
    @@ -1936,8 +1936,12 @@ static int enic_open(struct net_device *
    return 0;

    err_out_free_rq:
    - for (i = 0; i < enic->rq_count; i++)
    + for (i = 0; i < enic->rq_count; i++) {
    + err = vnic_rq_disable(&enic->rq[i]);
    + if (err)
    + return err;
    vnic_rq_clean(&enic->rq[i], enic_free_rq_buf);
    + }
    enic_dev_notify_unset(enic);
    err_out_free_intr:
    enic_unset_affinity_hint(enic);

    \
     
     \ /
      Last update: 2018-05-28 13:15    [W:4.138 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site