lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [GIT PULL 16/20] lightnvm: error handling when whole line is bad
    Date
    > On 28 May 2018, at 10.58, Matias Bjørling <mb@lightnvm.io> wrote:
    >
    > From: Igor Konopko <igor.j.konopko@intel.com>
    >
    > When all the blocks (chunks) in line are marked as bad (offline)
    > we shouldn't try to read smeta during init process.
    >
    > Currently we are trying to do so by passing -1 as PPA address,
    > what causes multiple warnings, that we issuing IOs to out-of-bound
    > PPAs.
    >
    > Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
    > Signed-off-by: Marcin Dziegielewski <marcin.dziegielewski@intel.com>
    > Updated title.
    > Signed-off-by: Matias Bjørling <mb@lightnvm.io>
    > ---
    > drivers/lightnvm/pblk-core.c | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
    > index a20b41c355c5..e3e883547198 100644
    > --- a/drivers/lightnvm/pblk-core.c
    > +++ b/drivers/lightnvm/pblk-core.c
    > @@ -868,6 +868,11 @@ int pblk_line_read_smeta(struct pblk *pblk, struct pblk_line *line)
    > {
    > u64 bpaddr = pblk_line_smeta_start(pblk, line);
    >
    > + if (bpaddr == -1) {
    > + /* Whole line is bad - do not try to read smeta. */
    > + return 1;
    > + }

    This case cannot occur on the only user of the function
    (pblk_recov_l2p()). On the previous check (pblk_line_was_written()), we
    verify the state of the line and the position of the first good chunk. In
    the case of a bad line (less chunks than a given threshold to allow
    emeta), the recovery will not be carried out in the line.

    Javier
    \
     
     \ /
      Last update: 2018-05-28 12:59    [W:3.182 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site