lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 13/15] arm: dts: r8a7743: Add missing OPP properties for CPUs
    [Cc Biju Das]

    On Fri, May 25, 2018 at 04:01:59PM +0530, Viresh Kumar wrote:
    > The OPP properties, like "operating-points", should either be present
    > for all the CPUs of a cluster or none. If these are present only for a
    > subset of CPUs of a cluster then things will start falling apart as soon
    > as the CPUs are brought online in a different order. For example, this
    > will happen because the operating system looks for such properties in
    > the CPU node it is trying to bring up, so that it can create an OPP
    > table.
    >
    > Add such missing properties.
    >
    > Fix other missing property (clock latency) as well to make it all
    > work.
    >
    > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

    Thanks, this looks good to me and it looks like it should have:

    Fixes: 0417814ea140 ("ARM: dts: r8a7743: Add OPP table for frequency scaling")

    Biju, as the author of the above patch could you take a look over this fix?

    > ---
    > arch/arm/boot/dts/r8a7743.dtsi | 9 +++++++++
    > 1 file changed, 9 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
    > index 142949d7066f..e4fb31c4f0ee 100644
    > --- a/arch/arm/boot/dts/r8a7743.dtsi
    > +++ b/arch/arm/boot/dts/r8a7743.dtsi
    > @@ -98,8 +98,17 @@
    > reg = <1>;
    > clock-frequency = <1500000000>;
    > clocks = <&cpg CPG_CORE R8A7743_CLK_Z>;
    > + clock-latency = <300000>; /* 300 us */
    > power-domains = <&sysc R8A7743_PD_CA15_CPU1>;
    > next-level-cache = <&L2_CA15>;
    > +
    > + /* kHz - uV - OPPs unknown yet */
    > + operating-points = <1500000 1000000>,
    > + <1312500 1000000>,
    > + <1125000 1000000>,
    > + < 937500 1000000>,
    > + < 750000 1000000>,
    > + < 375000 1000000>;
    > };
    >
    > L2_CA15: cache-controller-0 {
    > --
    > 2.15.0.194.g9af6a3dea062
    >

    \
     
     \ /
      Last update: 2018-05-28 11:25    [W:2.318 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site