lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 035/268] ipmi/powernv: Fix error return code in ipmi_powernv_probe()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit e749d328b0b450aa78d562fa26a0cd8872325dd9 ]

    Fix to return a negative error code from the request_irq() error
    handling case instead of 0, as done elsewhere in this function.

    Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
    Signed-off-by: Corey Minyard <cminyard@mvista.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/ipmi/ipmi_powernv.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/char/ipmi/ipmi_powernv.c
    +++ b/drivers/char/ipmi/ipmi_powernv.c
    @@ -251,8 +251,9 @@ static int ipmi_powernv_probe(struct pla
    ipmi->irq = opal_event_request(prop);
    }

    - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
    - "opal-ipmi", ipmi)) {
    + rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
    + "opal-ipmi", ipmi);
    + if (rc) {
    dev_warn(dev, "Unable to request irq\n");
    goto err_dispose;
    }

    \
     
     \ /
      Last update: 2018-05-28 18:02    [W:4.070 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site