Messages in this thread | | | Date | Mon, 28 May 2018 06:12:09 -0700 | From | Davidlohr Bueso <> | Subject | Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON |
| |
On Mon, 28 May 2018, Herbert Xu wrote: >I don't really see why we need these WARN_ONs. The problem should >be quite obvious when you're writing your code. > >If you really want them perhaps add them to the ipc code instead?
Well, I don't really _want_ them; nor does the ipc code which already does a WARN_ON() (but that goes away in future patches). What I want is to get rid of the return path. So I don't really care if we convert them to WARN or remove them altogether. Would you be happy with the later?
Thanks, Davidlohr
| |