lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 127/268] scsi: mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hannes Reinecke <hare@suse.de>

    [ Upstream commit 864449eea7c600596e305ffdc4a6a846414b222c ]

    The firmware event workqueue should not be marked as WQ_MEM_RECLAIM
    as it's doesn't need to make forward progress under memory pressure.
    In the current state it will result in a deadlock if the device had been
    forcefully removed.

    Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
    Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
    Acked-by: Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>
    Signed-off-by: Hannes Reinecke <hare@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
    +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
    @@ -8637,7 +8637,7 @@ _scsih_probe(struct pci_dev *pdev, const
    snprintf(ioc->firmware_event_name, sizeof(ioc->firmware_event_name),
    "fw_event_%s%d", ioc->driver_name, ioc->id);
    ioc->firmware_event_thread = alloc_ordered_workqueue(
    - ioc->firmware_event_name, WQ_MEM_RECLAIM);
    + ioc->firmware_event_name, 0);
    if (!ioc->firmware_event_thread) {
    pr_err(MPT3SAS_FMT "failure at %s:%d/%s()!\n",
    ioc->name, __FILE__, __LINE__, __func__);

    \
     
     \ /
      Last update: 2018-05-28 17:30    [W:4.135 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site