lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 133/268] bnxt_en: Check valid VNIC ID in bnxt_hwrm_vnic_set_tpa().
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Michael Chan <michael.chan@broadcom.com>

    [ Upstream commit 3c4fe80b32c685bdc02b280814d0cfe80d441c72 ]

    During initialization, if we encounter errors, there is a code path that
    calls bnxt_hwrm_vnic_set_tpa() with invalid VNIC ID. This may cause a
    warning in firmware logs.

    Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -2925,6 +2925,9 @@ static int bnxt_hwrm_vnic_set_tpa(struct
    struct bnxt_vnic_info *vnic = &bp->vnic_info[vnic_id];
    struct hwrm_vnic_tpa_cfg_input req = {0};

    + if (vnic->fw_vnic_id == INVALID_HW_RING_ID)
    + return 0;
    +
    bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_VNIC_TPA_CFG, -1, -1);

    if (tpa_flags) {

    \
     
     \ /
      Last update: 2018-05-28 17:29    [W:3.939 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site