Messages in this thread | | | Date | Mon, 28 May 2018 17:07:20 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH 5/8] signal: flatten do_send_sig_info() |
| |
On Mon, May 28, 2018 at 03:15:37PM +0100, Al Viro wrote: > On Mon, May 28, 2018 at 03:49:13PM +0200, Christian Brauner wrote: > > Let's return early when lock_task_sighand() fails and move send_signal() > > and unlock_task_sighand() out of the if block. > > Why is it an improvement?
I prefer to return early if I know I can and have the bigger portion of the code move out of the if-branch. But that's - let's say - an opinionated improvement.
Christian
| |