lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 022/329] KVM: s390: vsie: fix < 8k check for the itdba
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Hildenbrand <david@redhat.com>

    commit f4a551b72358facbbe5714248dff78404272feee upstream.

    By missing an "L", we might detect some addresses to be <8k,
    although they are not.

    e.g. for itdba = 100001fff
    !(gpa & ~0x1fffU) -> 1
    !(gpa & ~0x1fffUL) -> 0

    So we would report a SIE validity intercept although everything is fine.

    Fixes: 166ecb3 ("KVM: s390: vsie: support transactional execution")
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Cornelia Huck <cohuck@redhat.com>
    Signed-off-by: David Hildenbrand <david@redhat.com>
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Cc: stable@vger.kernel.org # v4.8+
    Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/s390/kvm/vsie.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/s390/kvm/vsie.c
    +++ b/arch/s390/kvm/vsie.c
    @@ -549,7 +549,7 @@ static int pin_blocks(struct kvm_vcpu *v

    gpa = scb_o->itdba & ~0xffUL;
    if (gpa && (scb_s->ecb & 0x10U)) {
    - if (!(gpa & ~0x1fffU)) {
    + if (!(gpa & ~0x1fffUL)) {
    rc = set_validity_icpt(scb_s, 0x0080U);
    goto unpin;
    }

    \
     
     \ /
      Last update: 2018-05-28 16:58    [W:4.023 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site