lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 196/329] workqueue: use put_device() instead of kfree()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arvind Yadav <arvind.yadav.cs@gmail.com>

    [ Upstream commit 537f4146c53c95aac977852b371bafb9c6755ee1 ]

    Never directly free @dev after calling device_register(), even
    if it returned an error! Always use put_device() to give up the
    reference initialized in this function instead.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/workqueue.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/workqueue.c
    +++ b/kernel/workqueue.c
    @@ -5272,7 +5272,7 @@ int workqueue_sysfs_register(struct work

    ret = device_register(&wq_dev->dev);
    if (ret) {
    - kfree(wq_dev);
    + put_device(&wq_dev->dev);
    wq->wq_dev = NULL;
    return ret;
    }

    \
     
     \ /
      Last update: 2018-05-28 16:22    [W:4.095 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site