Messages in this thread Patch in this message | | | From | Christian Brauner <> | Subject | [PATCH 5/8] signal: flatten do_send_sig_info() | Date | Mon, 28 May 2018 15:49:13 +0200 |
| |
Let's return early when lock_task_sighand() fails and move send_signal() and unlock_task_sighand() out of the if block.
Signed-off-by: Christian Brauner <christian@brauner.io> --- kernel/signal.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c index 821b54e3328b..498b464fe862 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1167,16 +1167,16 @@ specific_send_sig_info(int sig, struct siginfo *info, struct task_struct *t) } int do_send_sig_info(int sig, struct siginfo *info, struct task_struct *p, - bool group) + bool group) { unsigned long flags; int ret = -ESRCH; - if (lock_task_sighand(p, &flags)) { - ret = send_signal(sig, info, p, group); - unlock_task_sighand(p, &flags); - } + if (!lock_task_sighand(p, &flags)) + return ret; + ret = send_signal(sig, info, p, group); + unlock_task_sighand(p, &flags); return ret; } -- 2.17.0
| |