lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 097/496] gpu: ipu-v3: pre: fix device node leak in ipu_pre_lookup_by_phandle
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tobias Jordan <Tobias.Jordan@elektrobit.com>

    [ Upstream commit c795f3052b60b01e80485fad98c53e5e67d093c9 ]

    Before returning, call of_node_put() for the device node returned by
    of_parse_phandle().

    Fixes: d2a34232580a ("gpu: ipu-v3: add driver for Prefetch Resolve Engine")
    Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/ipu-v3/ipu-pre.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/gpu/ipu-v3/ipu-pre.c
    +++ b/drivers/gpu/ipu-v3/ipu-pre.c
    @@ -125,11 +125,14 @@ ipu_pre_lookup_by_phandle(struct device
    if (pre_node == pre->dev->of_node) {
    mutex_unlock(&ipu_pre_list_mutex);
    device_link_add(dev, pre->dev, DL_FLAG_AUTOREMOVE);
    + of_node_put(pre_node);
    return pre;
    }
    }
    mutex_unlock(&ipu_pre_list_mutex);

    + of_node_put(pre_node);
    +
    return NULL;
    }


    \
     
     \ /
      Last update: 2018-05-28 15:36    [W:3.595 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site