lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 071/496] ARM: OMAP1: clock: Fix debugfs_create_*() usage
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 8cbbf1745dcde7ba7e423dc70619d223de90fd43 ]

    When exposing data access through debugfs, the correct
    debugfs_create_*() functions must be used, depending on data type.

    Remove all casts from data pointers passed to debugfs_create_*()
    functions, as such casts prevent the compiler from flagging bugs.

    Correct all wrong usage:
    - clk.rate is unsigned long, not u32,
    - clk.flags is u8, not u32, which exposed the successive
    clk.rate_offset and clk.src_offset fields.

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/arm/mach-omap1/clock.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/arch/arm/mach-omap1/clock.c
    +++ b/arch/arm/mach-omap1/clock.c
    @@ -1011,17 +1011,17 @@ static int clk_debugfs_register_one(stru
    return -ENOMEM;
    c->dent = d;

    - d = debugfs_create_u8("usecount", S_IRUGO, c->dent, (u8 *)&c->usecount);
    + d = debugfs_create_u8("usecount", S_IRUGO, c->dent, &c->usecount);
    if (!d) {
    err = -ENOMEM;
    goto err_out;
    }
    - d = debugfs_create_u32("rate", S_IRUGO, c->dent, (u32 *)&c->rate);
    + d = debugfs_create_ulong("rate", S_IRUGO, c->dent, &c->rate);
    if (!d) {
    err = -ENOMEM;
    goto err_out;
    }
    - d = debugfs_create_x32("flags", S_IRUGO, c->dent, (u32 *)&c->flags);
    + d = debugfs_create_x8("flags", S_IRUGO, c->dent, &c->flags);
    if (!d) {
    err = -ENOMEM;
    goto err_out;

    \
     
     \ /
      Last update: 2018-05-28 15:36    [W:3.649 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site