lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 243/496] can: m_can: change comparison to bitshift when dealing with a mask
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wolfram Sang <wsa+renesas@sang-engineering.com>

    [ Upstream commit b7db978ac283b237835129ac87f26cbac94d04e7 ]

    Due to a typo, the mask was destroyed by a comparison instead of a bit
    shift.

    Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/m_can/m_can.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/can/m_can/m_can.c
    +++ b/drivers/net/can/m_can/m_can.c
    @@ -246,7 +246,7 @@ enum m_can_mram_cfg {

    /* Rx FIFO 0/1 Configuration (RXF0C/RXF1C) */
    #define RXFC_FWM_SHIFT 24
    -#define RXFC_FWM_MASK (0x7f < RXFC_FWM_SHIFT)
    +#define RXFC_FWM_MASK (0x7f << RXFC_FWM_SHIFT)
    #define RXFC_FS_SHIFT 16
    #define RXFC_FS_MASK (0x7f << RXFC_FS_SHIFT)


    \
     
     \ /
      Last update: 2018-05-28 14:59    [W:4.277 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site