lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver
    Hi Benjamin,

    On Thu, 24 May 2018 13:30:14 +0200
    Benjamin Lindqvist <benjamin.lindqvist@endian.se> wrote:

    > Hi Stefan,
    >
    > It seems to me that a probe similar to what the BootROM does shouldn't
    > be awfully complicated to implement - just cycle through the switch
    > cases in case of an ECC error. But I guess that's more of an idea for
    > further improvements rather than a comment to the patch set under
    > review.

    Nope, not really an option, because you're not guaranteed that the NAND
    will be used as a boot media, and the first page or first set of pages
    might just be erased.

    >
    > However, I think that allowing for an override of the oobsize
    > inference would be a good idea before merging, no? This could just be
    > a trivial #ifdef (at least temporarily). If you agree but don't feel
    > like doing it yourself, I'd be happy to pitch in. Let me know.

    That's why we have nand-ecc-xxx properties in the DT.

    Regards,

    Boris

    \
     
     \ /
      Last update: 2018-05-24 13:54    [W:4.177 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site