lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 43/96] usb: gadget: udc: change comparison to bitshift when dealing with a mask
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wolfram Sang <wsa+renesas@sang-engineering.com>

    [ Upstream commit ac87e560f7c0f91b62012e9a159c0681a373b922 ]

    Due to a typo, the mask was destroyed by a comparison instead of a bit
    shift.

    Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/udc/goku_udc.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/gadget/udc/goku_udc.h
    +++ b/drivers/usb/gadget/udc/goku_udc.h
    @@ -28,7 +28,7 @@ struct goku_udc_regs {
    # define INT_EP1DATASET 0x00040
    # define INT_EP2DATASET 0x00080
    # define INT_EP3DATASET 0x00100
    -#define INT_EPnNAK(n) (0x00100 < (n)) /* 0 < n < 4 */
    +#define INT_EPnNAK(n) (0x00100 << (n)) /* 0 < n < 4 */
    # define INT_EP1NAK 0x00200
    # define INT_EP2NAK 0x00400
    # define INT_EP3NAK 0x00800

    \
     
     \ /
      Last update: 2018-05-24 13:42    [W:7.422 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site