lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 49/96] staging: lustre: lmv: correctly iput lmo_root
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.com>

    [ Upstream commit 17556cdbe6ed70a6a20e597b228628f7f34387f8 ]

    Commit 8f18c8a48b73 ("staging: lustre: lmv: separate master object
    with master stripe") changed how lmo_root inodes were managed,
    particularly when LMV_HASH_FLAG_MIGRATION is not set.
    Previously lsm_md_oinfo[0].lmo_root was always a borrowed
    inode reference and didn't need to by iput().
    Since the change, that special case only applies when
    LMV_HASH_FLAG_MIGRATION is set

    In the upstream (lustre-release) version of this patch [Commit
    60e07b972114 ("LU-4690 lod: separate master object with master
    stripe")] the for loop in the lmv_unpack_md() was changed to count
    from 0 and to ignore entry 0 if LMV_HASH_FLAG_MIGRATION is set.
    In the patch that got applied to Linux, that change was missing,
    so lsm_md_oinfo[0].lmo_root is never iput().
    This results in a "VFS: Busy inodes" warning at unmount.

    Fixes: 8f18c8a48b73 ("staging: lustre: lmv: separate master object with master stripe")
    Signed-off-by: NeilBrown <neilb@suse.com>
    Reviewed-by: James Simmons <jsimmons@infradead.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
    +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
    @@ -2928,7 +2928,7 @@ int lmv_unpack_md(struct obd_export *exp
    if (lsm && !lmm) {
    int i;

    - for (i = 1; i < lsm->lsm_md_stripe_count; i++) {
    + for (i = 0; i < lsm->lsm_md_stripe_count; i++) {
    /*
    * For migrating inode, the master stripe and master
    * object will be the same, so do not need iput, see

    \
     
     \ /
      Last update: 2018-05-24 13:40    [W:4.808 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site