lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 48/96] staging: rtl8192u: return -ENOMEM on failed allocation of priv->oldaddr
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit e1a7418529e33bc4efc346324557251a16a3e79b ]

    Currently the allocation of priv->oldaddr is not null checked which will
    lead to subsequent errors when accessing priv->oldaddr. Fix this with
    a null pointer check and a return of -ENOMEM on allocation failure.

    Detected with Coccinelle:
    drivers/staging/rtl8192u/r8192U_core.c:1708:2-15: alloc with no test,
    possible model on line 1723

    Fixes: 8fc8598e61f6 ("Staging: Added Realtek rtl8192u driver to staging")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/rtl8192u/r8192U_core.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/staging/rtl8192u/r8192U_core.c
    +++ b/drivers/staging/rtl8192u/r8192U_core.c
    @@ -1705,6 +1705,8 @@ static short rtl8192_usb_initendpoints(s

    priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL);
    priv->oldaddr = kmalloc(16, GFP_KERNEL);
    + if (!priv->oldaddr)
    + return -ENOMEM;
    oldaddr = priv->oldaddr;
    align = ((long)oldaddr) & 3;
    if (align) {

    \
     
     \ /
      Last update: 2018-05-24 13:39    [W:4.109 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site