lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 91/96] serial: fsl_lpuart: Fix out-of-bounds access through DT alias
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit ffab87fdecc655cc676f8be8dd1a2c5e22bd6d47 ]

    The lpuart_ports[] array is indexed using a value derived from the
    "serialN" alias in DT, which may lead to an out-of-bounds access.

    Fix this by adding a range check.

    Fixes: c9e2e946fb0ba5d2 ("tty: serial: add Freescale lpuart driver support")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/tty/serial/fsl_lpuart.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/tty/serial/fsl_lpuart.c
    +++ b/drivers/tty/serial/fsl_lpuart.c
    @@ -1902,6 +1902,10 @@ static int lpuart_probe(struct platform_
    dev_err(&pdev->dev, "failed to get alias id, errno %d\n", ret);
    return ret;
    }
    + if (ret >= ARRAY_SIZE(lpuart_ports)) {
    + dev_err(&pdev->dev, "serial%d out of range\n", ret);
    + return -EINVAL;
    + }
    sport->port.line = ret;
    sport->lpuart32 = of_device_is_compatible(np, "fsl,ls1021a-lpuart");


    \
     
     \ /
      Last update: 2018-05-24 13:32    [W:2.650 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site