lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 074/165] usb: dwc2: hcd: Fix host channel halt flow
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Minas Harutyunyan <hminas@synopsys.com>

    [ Upstream commit a82c7abdf8fc3b09c4a0ed2eee6d43ecef2ccdb0 ]

    According databook in Buffer and External DMA mode
    non-split periodic channels can't be halted.

    Acked-by: John Youn <johnyoun@synopsys.com>
    Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
    Signed-off-by: Grigor Tovmasyan <tovmasya@synopsys.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/dwc2/hcd.c | 18 ++++++++++++++++++
    1 file changed, 18 insertions(+)

    --- a/drivers/usb/dwc2/hcd.c
    +++ b/drivers/usb/dwc2/hcd.c
    @@ -979,6 +979,24 @@ void dwc2_hc_halt(struct dwc2_hsotg *hso

    if (dbg_hc(chan))
    dev_vdbg(hsotg->dev, "%s()\n", __func__);
    +
    + /*
    + * In buffer DMA or external DMA mode channel can't be halted
    + * for non-split periodic channels. At the end of the next
    + * uframe/frame (in the worst case), the core generates a channel
    + * halted and disables the channel automatically.
    + */
    + if ((hsotg->params.g_dma && !hsotg->params.g_dma_desc) ||
    + hsotg->hw_params.arch == GHWCFG2_EXT_DMA_ARCH) {
    + if (!chan->do_split &&
    + (chan->ep_type == USB_ENDPOINT_XFER_ISOC ||
    + chan->ep_type == USB_ENDPOINT_XFER_INT)) {
    + dev_err(hsotg->dev, "%s() Channel can't be halted\n",
    + __func__);
    + return;
    + }
    + }
    +
    if (halt_status == DWC2_HC_XFER_NO_HALT_STATUS)
    dev_err(hsotg->dev, "!!! halt_status = %d !!!\n", halt_status);


    \
     
     \ /
      Last update: 2018-05-24 13:09    [W:4.272 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site