lkml.org 
[lkml]   [2018]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 85/92] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alexander Potapenko <glider@google.com>

    commit a45b599ad808c3c982fdcdc12b0b8611c2f92824 upstream.

    This shall help avoid copying uninitialized memory to the userspace when
    calling ioctl(fd, SG_IO) with an empty command.

    Reported-by: syzbot+7d26fc1eea198488deab@syzkaller.appspotmail.com
    Cc: stable@vger.kernel.org
    Signed-off-by: Alexander Potapenko <glider@google.com>
    Acked-by: Douglas Gilbert <dgilbert@interlog.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/sg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/sg.c
    +++ b/drivers/scsi/sg.c
    @@ -1903,7 +1903,7 @@ retry:
    num = (rem_sz > scatter_elem_sz_prev) ?
    scatter_elem_sz_prev : rem_sz;

    - schp->pages[k] = alloc_pages(gfp_mask, order);
    + schp->pages[k] = alloc_pages(gfp_mask | __GFP_ZERO, order);
    if (!schp->pages[k])
    goto out;


    \
     
     \ /
      Last update: 2018-05-24 11:47    [W:3.029 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site