Messages in this thread | | | Date | Thu, 24 May 2018 18:59:40 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver |
| |
On Thu, May 24, 2018 at 05:51:27PM +0000, Vaittinen, Matti wrote:
> > what is the lock doing and what is this wrapper function intended to do?
> This was the other spot which I was unsure how to handle. Datasheet for > the chip says that if voltage is to be changed, the regulator must be > disabled. Thus my voltage changing function checks if regulator is enabled
Ugh, this chip is not very good is it? Don't bounce the supply to change the voltage silently, that's clearly a bad idea - the devices using the supply are going to get very upset when the power gets removed just because they changed the voltage. Instead implement a custom set operation that returns an error if the user attempts to change the voltage while the regualtor is enabled. [unhandled content-type:application/pgp-signature] | |