Messages in this thread | | | Date | Wed, 23 May 2018 11:44:23 -0500 | From | Rob Herring <> | Subject | Re: [PATCH] of: overlay: validate offset from property fixups |
| |
On Wed, May 16, 2018 at 09:19:51PM -0700, frowand.list@gmail.com wrote: > From: Frank Rowand <frank.rowand@sony.com> > > The smatch static checker marks the data in offset as untrusted, > leading it to warn: > > drivers/of/resolver.c:125 update_usages_of_a_phandle_reference() > error: buffer underflow 'prop->value' 's32min-s32max' > > Add check to verify that offset is within the property data. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > --- > drivers/of/resolver.c | 5 +++++ > 1 file changed, 5 insertions(+)
Applied, thanks.
Rob
| |