Messages in this thread | | | Date | Wed, 23 May 2018 08:22:54 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH] irqchip: gpcv2: remove unnecessary functions |
| |
On Wed, 23 May 2018 07:23:00 +0100, Anson Huang wrote: > > GPC is in always-on domain, it never lost its > content during suspend/resume, so no need to > do save/restore for it during suspend/resume. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > drivers/irqchip/irq-imx-gpcv2.c | 41 ----------------------------------------- > 1 file changed, 41 deletions(-) > > diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c > index 4760307..e6025d9 100644 > --- a/drivers/irqchip/irq-imx-gpcv2.c > +++ b/drivers/irqchip/irq-imx-gpcv2.c > @@ -28,46 +28,6 @@ struct gpcv2_irqchip_data { > > static struct gpcv2_irqchip_data *imx_gpcv2_instance; > > -static int gpcv2_wakeup_source_save(void) > -{ > - struct gpcv2_irqchip_data *cd; > - void __iomem *reg; > - int i; > - > - cd = imx_gpcv2_instance; > - if (!cd) > - return 0; > - > - for (i = 0; i < IMR_NUM; i++) { > - reg = cd->gpc_base + cd->cpu2wakeup + i * 4; > - cd->saved_irq_mask[i] = readl_relaxed(reg); > - writel_relaxed(cd->wakeup_sources[i], reg); > - }
If you're removing that code, what's the purpose of keeping saved_irq_mask?
Also, who is now programming the wake-up_source? For good or bad reasons, this drivers uses the save/restore hooks to program the wake-up state. Removing this code seem to simply kill the feature.
What am I missing?
Thanks,
M.
-- Jazz is not dead, it just smell funny.
| |