Messages in this thread | | | Subject | Re: [PATCH v6 1/2] acpi: apei: Rename ghes_severity() to ghes_cper_severity() | From | "Alex G." <> | Date | Tue, 22 May 2018 09:39:15 -0500 |
| |
On 05/22/2018 08:50 AM, Borislav Petkov wrote: > On Tue, May 22, 2018 at 08:38:39AM -0500, Alex G. wrote: >>> It looks like the *real* reason for this change is that you >>> re-introduce ghes_severity() as a different function in the second >>> patch. >> >> /me holds fist at Borislav > > That was a misunderstanding with Rafael and me - we fixed it on IRC.
You mean to say this whole time I've been struggling to write emails, there was an IRC?
> But this is not the real problem with your approach - it is the marking > of all PCIe errors as recoverable, regardless of the signature. That's a > no-no, IMO.
No, the problem is with the current approach, not with mine. The problem is trying to handle the error outside of the existing handler. That's a no-no, IMO.
Alex
| |