Messages in this thread | | | Subject | Re: [PATCH V4 13/38] x86/intel_rdt: Introduce "bit_usage" to display cache allocations details | From | Reinette Chatre <> | Date | Tue, 22 May 2018 14:09:47 -0700 |
| |
Hi Randy,
On 5/22/2018 2:03 PM, Randy Dunlap wrote: > On 05/22/2018 04:29 AM, Reinette Chatre wrote: >> With cache regions now explicitly marked as "shareable" or "exclusive" >> we would like to communicate to the user how portions of the cache >> are used. >> >> Introduce "bit_usage" that indicates for each resource >> how portions of the cache are configured to be used. >> >> To assist the user to distinguish whether the sharing is from software or >> hardware we add the following annotation: >> >> 0 - currently unused >> X - currently available for sharing and used by software and hardware >> H - currently used by hardware only but available for software use >> S - currently used and shareable by software only >> E - currently used exclusively by one resource group >> >> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> >> --- >> arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 79 ++++++++++++++++++++++++++++++++ >> 1 file changed, 79 insertions(+) >> > > Hi, > > All occurrences of seq_puts(f, one_char_string); should instead be > seq_putc(f, one_char); > > Same for patch 14.
Thank you very much for catching this. Will do.
Reinette
| |