lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 19/33] thermal: db8500: use match_string() helper
    On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
    > match_string() returns the index of an array for a matching string,
    > which can be used intead of open coded variant.

    > + i = match_string((const char **)trip_point->cdev_name,

    Casting looks ugly. You need to constify the variable itself.

    > + COOLING_DEV_MAX, cdev->type);
    >
    > - return -ENODEV;
    > + return (i < 0) ? -ENODEV : 0;

    I would rather go with

    if (ret < 0)
    return -ENODEV;

    return 0;

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2018-05-22 00:01    [W:5.425 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site