Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 22 May 2018 01:00:23 +0300 | Subject | Re: [PATCH 19/33] thermal: db8500: use match_string() helper |
| |
On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant.
> + i = match_string((const char **)trip_point->cdev_name,
Casting looks ugly. You need to constify the variable itself.
> + COOLING_DEV_MAX, cdev->type); > > - return -ENODEV; > + return (i < 0) ? -ENODEV : 0;
I would rather go with
if (ret < 0) return -ENODEV;
return 0;
-- With Best Regards, Andy Shevchenko
| |