Messages in this thread | | | Subject | Re: [PATCH v6 17/28] x86/asm: use SYM_INNER_LABEL instead of GLOBAL | From | Jiri Slaby <> | Date | Mon, 21 May 2018 09:13:15 +0200 |
| |
On 05/18/2018, 09:41 PM, Andy Lutomirski wrote: > On Fri, May 18, 2018 at 2:17 AM Jiri Slaby <jslaby@suse.cz> wrote: > >> GLOBAL had several meanings and is going away. In this patch, convert >> all the inner function labels marked with GLOBAL to use SYM_INNER_LABEL >> instead. > >> Note that retint_user needs not be global, perhaps since commit >> 2ec67971facc ("x86/entry/64/compat: Remove most of the fast system call >> machinery"), where entry_64_compat's caller was removed. So mark the >> label as LOCAL. > > >> -GLOBAL(entry_SYSCALL_64_after_hwframe) >> +SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL) > > I've missed all the context here. I agree that GLOBAL is misleading, and > "inner label" is nice. But this is a rather wordy macro. Would: > > INNER_LABEL_GLOBAL(name) > > be better? (With just INNER_LABEL(name) for the local version?)
All the macros have SYM_ prefix. Other macros look like this: SYM_FUNC_START_LOCAL(name) SYM_FUNC_START(name)
So I can make the inner one: SYM_INNER_LABEL_LOCAL(name) SYM_INNER_LABEL(name)
to be consistent with the rest, if that is OK?
thanks, -- js suse labs
| |