lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth
    From
    Date


    On 05/21/2018 06:28 AM, Michal Vokáč wrote:
    > By default autonegotiation is enabled to configure MAC on all ports.
    > For the CPU port autonegotiation can not be used so we need to set
    > some sensible defaults manually.
    >
    > This patch forces the default setting of the CPU port to 1000Mbps/full
    > duplex which is the chip maximum capability.
    >
    > Also correct size of the bit field used to configure link speed.
    >
    > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

    Likewise, would not we want to have a:

    Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")

    tag here as well?
    --
    Florian

    \
     
     \ /
      Last update: 2018-05-21 17:20    [W:4.152 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site