lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/52] perf check-headers.sh: Simplify arguments passing
    Date
    From: Jiri Olsa <jolsa@kernel.org>

    Passing whole string instead of parsing them after. It simplifies
    things for the next patches, that adds another function call, which
    makes it hard to pass arguments in the correct shape.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20180423090823.32309-2-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/check-headers.sh | 15 +++++----------
    1 file changed, 5 insertions(+), 10 deletions(-)

    diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
    index 9aff89bc7535..88c5f9449809 100755
    --- a/tools/perf/check-headers.sh
    +++ b/tools/perf/check-headers.sh
    @@ -59,13 +59,8 @@ check () {
    file=$1

    shift
    - opts=
    - while [ -n "$*" ]; do
    - opts="$opts \"$1\""
    - shift
    - done

    - cmd="diff $opts ../$file ../../$file > /dev/null"
    + cmd="diff $* ../$file ../../$file > /dev/null"

    test -f ../../$file &&
    eval $cmd || echo "Warning: Kernel ABI header at 'tools/$file' differs from latest version at '$file'" >&2
    @@ -83,7 +78,7 @@ for i in $HEADERS; do
    done

    # diff with extra ignore lines
    -check arch/x86/lib/memcpy_64.S -I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"
    -check arch/x86/lib/memset_64.S -I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"
    -check include/uapi/asm-generic/mman.h -I "^#include <\(uapi/\)*asm-generic/mman-common.h>"
    -check include/uapi/linux/mman.h -I "^#include <\(uapi/\)*asm/mman.h>"
    +check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"'
    +check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"'
    +check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common.h>"'
    +check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"'
    --
    2.14.3
    \
     
     \ /
      Last update: 2018-05-02 17:34    [W:3.528 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site