lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings
Date
Quoting Taniya Das (2018-05-02 03:51:16)
> Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
> devices would be used for communicating resource state requests to control
> the clocks managed by RPMh.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

When you change things you shouldn't keep around reviewed-by tags if it
significantly changes..

> +Example :
> +
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +
> + &apps_rsc {
> + rpmhcc: clock-controller {
> + compatible = "qcom,sdm845-rpmh-clk";
> + #clock-cells = <1>;
> + assigned-clocks = <&clock_rpmh RPMH_CXO_CLK>,
> + <&clock_rpmh RPMH_CXO_CLK_A>,
> + <&clock_rpmh RPMH_LN_BB_CLK2>,
> + <&clock_rpmh RPMH_LN_BB_CLK2_A>,
> + <&clock_rpmh RPMH_LN_BB_CLK3>,
> + <&clock_rpmh RPMH_LN_BB_CLK3_A>;
> + assigned-clock-parents = <&xo_board_div>,
> + <&xo_board_div>,
> + <&xo_board_div>,
> + <&xo_board_div>,
> + <&xo_board_div>,
> + <&xo_board_div>,

There's only one parent, so assigned-clock-parents doesn't really make
sense. If anything, we would have 'clocks = ' here and specify the xo
board clk and the div 2 clk that live in DT. But I already merged this
binding, two patchsets ago. Please look in clk-next.

> + };
> +#define RPMH_RF_CLK2 8
> +#define RPMH_RF_CLK2_A 9
> +#define RPMH_RF_CLK3 10
> +#define RPMH_RF_CLK3_A 11
> +

Ok. I dropped CLK4* from the previous patch you sent and dropped Amit's
signed-off-by.

\
 
 \ /
  Last update: 2018-05-02 17:14    [W:0.129 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site