lkml.org 
[lkml]   [2018]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [greybus-dev] [PATCH v2] staging: greybus: Use gpio_is_valid()
    On 28-04-18, 10:05, Arvind Yadav wrote:
    > Replace the manual validity checks for the GPIO with the
    > gpio_is_valid().
    >
    > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    > ---
    > chnage in v2 :
    > Returning invalid gpio as error instead of -ENODEV.
    >
    > drivers/staging/greybus/arche-platform.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
    > index 83254a7..c3a7da5 100644
    > --- a/drivers/staging/greybus/arche-platform.c
    > +++ b/drivers/staging/greybus/arche-platform.c
    > @@ -448,7 +448,7 @@ static int arche_platform_probe(struct platform_device *pdev)
    > arche_pdata->svc_reset_gpio = of_get_named_gpio(np,
    > "svc,reset-gpio",
    > 0);
    > - if (arche_pdata->svc_reset_gpio < 0) {
    > + if (!gpio_is_valid(arche_pdata->svc_reset_gpio)) {
    > dev_err(dev, "failed to get reset-gpio\n");
    > return arche_pdata->svc_reset_gpio;
    > }
    > @@ -468,7 +468,7 @@ static int arche_platform_probe(struct platform_device *pdev)
    > arche_pdata->svc_sysboot_gpio = of_get_named_gpio(np,
    > "svc,sysboot-gpio",
    > 0);
    > - if (arche_pdata->svc_sysboot_gpio < 0) {
    > + if (!gpio_is_valid(arche_pdata->svc_sysboot_gpio)) {
    > dev_err(dev, "failed to get sysboot gpio\n");
    > return arche_pdata->svc_sysboot_gpio;
    > }
    > @@ -487,7 +487,7 @@ static int arche_platform_probe(struct platform_device *pdev)
    > arche_pdata->svc_refclk_req = of_get_named_gpio(np,
    > "svc,refclk-req-gpio",
    > 0);
    > - if (arche_pdata->svc_refclk_req < 0) {
    > + if (!gpio_is_valid(arche_pdata->svc_refclk_req)) {
    > dev_err(dev, "failed to get svc clock-req gpio\n");
    > return arche_pdata->svc_refclk_req;
    > }

    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

    --
    viresh

    \
     
     \ /
      Last update: 2018-05-02 07:45    [W:6.674 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site