Messages in this thread | | | From | Nadav Amit <> | Subject | Re: [PATCH 2/6] x86: bug: prevent gcc distortions | Date | Fri, 18 May 2018 14:36:21 +0000 |
| |
Borislav Petkov <bp@alien8.de> wrote:
> On Fri, May 18, 2018 at 10:13:54AM +0200, Ingo Molnar wrote: >> Yes, that's my main worry too about all these inlining changes: >> the very, very marked reduction in the readability of assembly code. > > Same reaction here: the small improvements this brings is simply not > enough to sacrifice readability so much IMO.
I didn’t try too hard to find more affected (micro)benchmarks, but I am pretty sure there are: pretty much all the paravirt ops are currently not inlined, which can affect kernel operations that bang on the page-tables.
Notice that this is not an x86-specific issue. Other architectures, with not-as-good OOOE for instance, might incur higher overheads. So I don’t think that this issue should be ignored. | |