Messages in this thread Patch in this message | | | Date | Fri, 18 May 2018 01:56:19 -1000 | From | Joey Pabalinas <> | Subject | [PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS generation |
| |
Parsing `ls` is fragile at best and _will_ fail when $tree contains spaces. Replace this with a find-generated string and directly assign it to $ALLSOURCE_ARCHS; a subshell is implied by $(), so `cd` doesn't affect the current working directory.
Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/scripts/tags.sh b/scripts/tags.sh index 78e546ff689c2d5f40..c08347fdeef12a7621 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -26,24 +26,15 @@ else fi # ignore userspace tools ignore="$ignore ( -path ${tree}tools ) -prune -o" -# Find all available archs -find_all_archs() -{ - ALLSOURCE_ARCHS="" - for arch in `ls ${tree}arch`; do - ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS} "${arch##\/} - done -} - # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH if [ "${ALLSOURCE_ARCHS}" = "" ]; then ALLSOURCE_ARCHS=${SRCARCH} elif [ "${ALLSOURCE_ARCHS}" = "all" ]; then - find_all_archs + ALLSOURCE_ARCHS="$(find "${tree}arch/" -mindepth 1 -maxdepth 1 -type d -printf ' %f')" fi # find sources in arch/$ARCH find_arch_sources() { -- 2.17.0.rc1.35.g90bbd502d54fe92035.dirty [unhandled content-type:application/pgp-signature] | |