Messages in this thread | | | Date | Thu, 17 May 2018 09:59:32 -0600 | From | Tycho Andersen <> | Subject | Re: [PATCH v2 3/4] seccomp: add a way to get a listener fd from ptrace |
| |
On Thu, May 17, 2018 at 09:57:33AM -0600, Tycho Andersen wrote: > On Thu, May 17, 2018 at 05:41:39PM +0200, Oleg Nesterov wrote: > > and since init_listener() does __get_seccomp_filter() on sucess, it is needed > > uncondtitionally? > > I think there does need to be a __get_seccomp_filter() on success in > init_listener(), because it's paired with the __put_seccomp_filter in > seccomp_notify_release. The listener fd has a reference to the filter, > and that shouldn't go away until after the fd is freed.
Oh, sorry. I see what you meant here. Yes, it should be unconditional.
Tycho
| |