Messages in this thread | | | From | "Ghannam, Yazen" <> | Subject | RE: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block | Date | Thu, 17 May 2018 14:05:39 +0000 |
| |
> -----Original Message----- > From: Borislav Petkov <bp@suse.de> > Sent: Thursday, May 17, 2018 9:44 AM > To: Ghannam, Yazen <Yazen.Ghannam@amd.com> > Cc: Johannes Hirte <johannes.hirte@datenkhaos.de>; linux- > edac@vger.kernel.org; linux-kernel@vger.kernel.org; tony.luck@intel.com; > x86@kernel.org > Subject: Re: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized > block > > On Thu, May 17, 2018 at 01:04:19PM +0000, Ghannam, Yazen wrote: ... > > I check PFEH is enabled how? >
If MISC0 is RAZ then you can assume PFEH is enabled. There should be a BIOS option to disable it.
BTW, I just tried you patch with PFEH disabled and it seems to work fine.
... > > Since we're caching the values during init, we can drop all the > > *_on_cpu() calls. What do you think? > > Well, if they're all the same on all CPUs, sure. That's your call. >
Let's drop them. We won't need them since we're caching the values during init. And the init code is run on the target CPU.
We can just make smca_bank_addrs[][] into per_cpu when we need to support different values on different CPUs.
Thanks, Yazen
| |