Messages in this thread | | | Subject | Re: [PATCH 4/4] media: venus: add PIL support | From | Trilok Soni <> | Date | Thu, 17 May 2018 17:40:49 -0700 |
| |
Hi Vikash,
On 5/17/2018 4:32 AM, Vikash Garodia wrote: > This adds support to load the video firmware > and bring ARM9 out of reset. This is useful > for platforms which does not have trustzone > to reset the ARM9.
ARM9 = video core here? May be commit text needs little bit more detail.
> > +static int store_firmware_dev(struct device *dev, void *data) > +{ > + struct venus_core *core; > + > + core = (struct venus_core *)data;
No need of casting.
> + if (!core) > + return -EINVAL; > + > + if (of_device_is_compatible(dev->of_node, "qcom,venus-pil-no-tz")) > + core->fw.dev = dev; > + > + return 0; > +} > +
> > - ret = venus_boot(dev, core->res->fwname); > + ret = of_platform_populate(dev->of_node, NULL, NULL, dev); > + if (ret) > + goto err_runtime_disable; > + > + /* Attempt to register child devices */ > + ret = device_for_each_child(dev, core, store_firmware_dev); > +
and not ret check needed?
> + ret = venus_boot(core); > if (ret) > goto err_runtime_disable; > > >
-- ---Trilok Soni Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |