lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 3/3] driver-core: print bus registration error value
From
Date
On 16.05.2018 14:05, Florian Schmaus wrote:
> Signed-off-by: Florian Schmaus <flo@geekplace.eu>
> ---
>
> Notes:
> - Use correct member name 'bus_register_error'
> - Only print out error code if it is non-zero
>
> drivers/base/bus.c | 4 +++-
> drivers/base/driver.c | 13 ++++++++++---
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index dce677dddba4..5814ecb07648 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -849,8 +849,10 @@ int bus_register(struct bus_type *bus)
> struct lock_class_key *key = &bus->lock_key;
>
> priv = kzalloc(sizeof(struct subsys_private), GFP_KERNEL);
> - if (!priv)
> + if (!priv) {
> + bus->bus_register_error = -ENOMEM;
> return -ENOMEM;
> + }
>
> priv->bus = bus;
> bus->p = priv;

I'm sorry, this change was meant to be part of 2/3 (and not 3/3). Shall
I send a v5 where this is fixed?

- Florian

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-05-16 14:10    [W:0.118 / U:6.864 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site