lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 06/10] tracing: Add trigger file for trace_markers tracefs/ftrace/print
On Wed, 16 May 2018 16:49:04 +0900
Namhyung Kim <namhyung@kernel.org> wrote:


> > Which will do:
> >
> > event_trigger_write() {
> > event_trigger_regex_write() {
> > trigger_process_regex() {
> > for p in trigger_commands {
> > p->func(); /* trigger_snapshot_cmd->func */
> > event_trigger_callback() {
> > cmd_ops->reg() /* register_trigger() */ {
> > trace_event_trigger_enable_disable() {
> > trace_event_enable_disable() {
> > call->class->reg();
> >
> > Without this patch, we jump to NULL and BOOM!
>
> Thanks for the explanation. I wonder we can skip calling
> trace_event_enable_disable() for events which have the
> TRACE_EVENT_FL_IGNORE_ENABLE flag.

Sounds like something we can do in the future. I rather have do the
minimal now as it will have the least side effects, and it's already
getting late in the current rc series. I'm looking to get this into the
next merge window.

But after that, changing it this way would be a nice clean up.

-- Steve

\
 
 \ /
  Last update: 2018-05-16 12:39    [W:0.024 / U:3.872 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site