lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler
On Wed, May 16, 2018 at 12:42:43AM +0000, Huang, Ying wrote:
> >> + unsigned long address = faddress & huge_page_mask(h);
> >
> > faddress? I would rather keep it address and rename maked out variable to
> > 'haddr'. We use 'haddr' for the cause in other places.
>
> I found haddr is popular in huge_memory.c but not used in hugetlb.c at
> all. Is it desirable to start to use "haddr" in hugetlb.c?

Yes, I think so. There's no reason to limit haddr convention to THP.

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2018-05-16 10:04    [W:0.048 / U:3.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site