lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] signal/mips: Report FPE_FLTUNK for undiagnosed floating point exceptions
Guenter Roeck <linux@roeck-us.net> writes:

> Most mips builds fail with
>
> arch/mips/kernel/traps.c: In function ‘force_fcr31_sig’:
> arch/mips/kernel/traps.c:732:2: error:
> ‘si_code’ may be used uninitialized in this function
>
> Fix the problem by initializing si_code with FPE_FLTUNK (undiagnosed
> floating point exception).
>
> Fixes: f43a54a0d916 ("signal/mips: Use force_sig_fault where appropriate")
> Cc: linux-mips@linux-mips.org
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Applied. Thank you.

Eric

> ---
> Feel free to merge into the patch introducing the problem.
>
> arch/mips/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 66ec4b0b484d..d67fa74622ee 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -716,7 +716,7 @@ asmlinkage void do_ov(struct pt_regs *regs)
> void force_fcr31_sig(unsigned long fcr31, void __user *fault_addr,
> struct task_struct *tsk)
> {
> - int si_code;
> + int si_code = FPE_FLTUNK;
>
> if (fcr31 & FPU_CSR_INV_X)
> si_code = FPE_FLTINV;

\
 
 \ /
  Last update: 2018-05-17 03:14    [W:0.029 / U:1.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site