lkml.org 
[lkml]   [2018]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN
On Tue, May 15, 2018 at 07:58:05PM +0200, Peter Zijlstra wrote:
> On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote:
> > +/*
> > + * Owner value to indicate the rwsem's owner is not currently known.
> > + */
> > +#define RWSEM_OWNER_UNKNOWN ((struct task_struct *)-1)
>
> It might be nice to comment that this works and relies on having that
> ANON_OWNER bit set.

I'd rather change the definition to be ((struct task_struct *)2)
otherwise this is both reader-owned and anonymously-owned which doesn't
make much sense.

\
 
 \ /
  Last update: 2018-05-15 20:03    [W:0.386 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site