Messages in this thread | | | Subject | Re: [PATCH v2 27/29] venus: implementing multi-stream support | From | Stanimir Varbanov <> | Date | Tue, 15 May 2018 12:40:24 +0300 |
| |
Hi Hans,
On 05/15/2018 11:17 AM, Hans Verkuil wrote: > Hi Stanimir, > > On 05/15/18 09:58, Stanimir Varbanov wrote: >> This is implementing a multi-stream decoder support. The multi >> stream gives an option to use the secondary decoder output >> with different raw format (or the same in case of crop). > > You told me that multi-stream support is currently internal only. > > It would be good if you could elaborate a bit about that in this > commit log and (I think) also add some comments in the code that > reflect this. > > It's also not clear to me how and why this is used in the driver > if this is just internal. Does it enable a feature you would > otherwise not be able to use? > > I have no complaints about the code, I would just like to see a > bit more background information in the source and commit log.
Thanks for the fast comments! Sure I will try to document multi-stream support in the patch description and in the code if it makes sense.
-- regards, Stan
| |