Messages in this thread | | | Subject | Re: [PATCH v6 09/11] firmware: xilinx: Add debugfs for clock control APIs | From | Sudeep Holla <> | Date | Tue, 15 May 2018 09:57:49 +0100 |
| |
On 14/05/18 20:18, Jolly Shah wrote: > Hi Sudeep,
[..]
>> >> As I mentioned in earlier patch, I don't see the need for this >> debugfs interface. Clock lay has read-only interface in debugfs >> already. Also if you want to debug clocks, you can do so using the >> driver which uses these clocks. Do you really want to manage clocks >> in user-space ? The whole idea of EEMI kind of interface is to >> abstract and hide the fine details even from non-trusted rich OS >> like Linux kernel, but by providing this you are doing exactly >> opposite. > > No we don't want to manage clocks in user-space. This debugfs is > meant for developer who wants to debug APIs behavior in case > something doesn't work as expected. Debugfs should be off by default > in production images. >
Good that it's not used in production image. The clock layer has *sufficient* debugfs support that will *help in debugging*. So please drop this Xilinx specific clock debugfs.
-- Regards, Sudeep
| |