Messages in this thread | | | From | Ulf Hansson <> | Date | Tue, 15 May 2018 09:59:30 +0200 | Subject | Re: [PATCH] driver core: Respect all error codes from dev_pm_domain_attach() |
| |
On 15 May 2018 at 06:46, Guenter Roeck <linux@roeck-us.net> wrote: > On Thu, Apr 26, 2018 at 10:53:06AM +0200, Ulf Hansson wrote: >> The limitation of being able to check only for -EPROBE_DEFER from >> dev_pm_domain_attach() has been removed. Hence let's respect all error >> codes and bail out accordingly. >> > > AFAICS this patch causes all drivers/devices to fail instantiating > if dev_pm_domain_set() is called in the device initialization path. > That seems to be a systemic problem, since dev_pm_domain_set() must > only be called for unbound devices. > > In practice, I see the problem when trying to boot beagle or overo > with qemu (the Linaro version). Of course, that doesn't mean much > because that is not real hardware. However, I am not surprised that > all devices instantiated through, for example, omap_device_build_from_dt() > fail to instantiate. Instrumentation confirms that dev_pm_domain_set() > is called prior to platform_drv_probe().
Your observations are correct, my bad! Others have also reported the problems.
This should solve it: https://patchwork.kernel.org/patch/10398597/
[...]
Kind regards Uffe
| |