Messages in this thread | | | Date | Tue, 15 May 2018 10:25:55 +0530 | From | kgunda@codeauro ... | Subject | Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral |
| |
On 2018-05-14 22:27, Pavel Machek wrote: > Hi! > >> WLED4 peripheral is present on some PMICs like pmi8998 >> and pm660l. It has a different register map and also >> configurations are different. Add support for it. >> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> >> --- >> .../bindings/leds/backlight/qcom-wled.txt | 172 ++++- >> drivers/video/backlight/qcom-wled.c | 749 >> +++++++++++++++------ >> 2 files changed, 696 insertions(+), 225 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt >> b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt >> index fb39e32..0ceffa1 100644 >> --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt >> +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt >> @@ -1,30 +1,129 @@ >> Binding for Qualcomm Technologies, Inc. WLED driver >> >> -Required properties: >> -- compatible: should be "qcom,pm8941-wled" >> -- reg: slave address >> - >> -Optional properties: >> -- default-brightness: brightness value on boot, value from: 0-4095 >> - default: 2048 >> +- compatible >> + Usage: required >> + Value type: <string> >> + Definition: should be "qcom,pm8941-wled" or "qcom,pmi8998-wled". >> + or "qcom,pm660l-wled". >> + >> +- reg >> + Usage: required >> + Value type: <prop encoded array> >> + Definition: Base address of the WLED modules. > > I'm not sure if this change of format is good idea here... > > Pavel > -- This format is clean and easily readable. That's why I have moved to this format. To avoid confusion, I will move out the existing properties (pm8941-wled.c) to other patch. So that it will be easy to review.
> To unsubscribe from this list: send the line "unsubscribe > linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |